Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UGRID-43: Handle SWIGTYPE_P_<T> #33

Open
wants to merge 51 commits into
base: main
Choose a base branch
from

Conversation

ahmad-el-sayed
Copy link
Contributor

No description provided.

Copy link
Contributor

@lucacarniato lucacarniato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, fews suggestions for improvements and one possible redundancy in implementing the dispose method

libs/UGridAPI/src/UGrid.cpp Show resolved Hide resolved
libs/UGridAPI/src/UGrid.cpp Show resolved Hide resolved
libs/UGridAPI/src/UGrid.cpp Show resolved Hide resolved
libs/UGridNET/SWIG/interface/UGridTypemaps.i Show resolved Hide resolved
libs/UGridNET/dll/src/Mesh1DExtensions.cs Outdated Show resolved Hide resolved
libs/UGridNET/dll/src/UGridWrapper.cs Outdated Show resolved Hide resolved
libs/UGridNET/dll/src/UGridReader.cs Outdated Show resolved Hide resolved
libs/UGridNET/dll/src/UGridReader.cs Show resolved Hide resolved
libs/UGridNET/dll/src/UGridReader.cs Outdated Show resolved Hide resolved
libs/UGridNET/dll/src/UGridWrapper.cs Outdated Show resolved Hide resolved
@ahmad-el-sayed ahmad-el-sayed marked this pull request as draft December 2, 2024 14:28
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@ahmad-el-sayed ahmad-el-sayed marked this pull request as ready for review December 18, 2024 09:27
libs/UGridAPI/src/UGrid.cpp Outdated Show resolved Hide resolved
libs/UGridNET/dll/src/ContactsExtensions.cs Show resolved Hide resolved
libs/UGridNET/dll/src/IntPtrExtensions.cs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants